Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1077 matching lines...) Expand 10 before | Expand all | Expand 10 after
1088 WebInspector.ConsoleViewFilter = function(view) 1088 WebInspector.ConsoleViewFilter = function(view)
1089 { 1089 {
1090 this._messageURLFiltersSetting = WebInspector.settings.createSetting("messag eURLFilters", {}); 1090 this._messageURLFiltersSetting = WebInspector.settings.createSetting("messag eURLFilters", {});
1091 this._messageLevelFiltersSetting = WebInspector.settings.createSetting("mess ageLevelFilters", {}); 1091 this._messageLevelFiltersSetting = WebInspector.settings.createSetting("mess ageLevelFilters", {});
1092 1092
1093 this._view = view; 1093 this._view = view;
1094 this._messageURLFilters = this._messageURLFiltersSetting.get(); 1094 this._messageURLFilters = this._messageURLFiltersSetting.get();
1095 this._filterChanged = this.dispatchEventToListeners.bind(this, WebInspector. ConsoleViewFilter.Events.FilterChanged); 1095 this._filterChanged = this.dispatchEventToListeners.bind(this, WebInspector. ConsoleViewFilter.Events.FilterChanged);
1096 }; 1096 };
1097 1097
1098 /** @enum {symbol} */
1098 WebInspector.ConsoleViewFilter.Events = { 1099 WebInspector.ConsoleViewFilter.Events = {
1099 FilterChanged: "FilterChanged" 1100 FilterChanged: Symbol("FilterChanged")
1100 }; 1101 };
1101 1102
1102 WebInspector.ConsoleViewFilter.prototype = { 1103 WebInspector.ConsoleViewFilter.prototype = {
1103 addFilters: function(filterBar) 1104 addFilters: function(filterBar)
1104 { 1105 {
1105 this._textFilterUI = new WebInspector.TextFilterUI(true); 1106 this._textFilterUI = new WebInspector.TextFilterUI(true);
1106 this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterC hanged, this._textFilterChanged, this); 1107 this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterC hanged, this._textFilterChanged, this);
1107 filterBar.addFilter(this._textFilterUI); 1108 filterBar.addFilter(this._textFilterUI);
1108 1109
1109 this._hideNetworkMessagesCheckbox = new WebInspector.CheckboxFilterUI("h ide-network-messages", WebInspector.UIString("Hide network messages"), true, Web Inspector.moduleSetting("hideNetworkMessages")); 1110 this._hideNetworkMessagesCheckbox = new WebInspector.CheckboxFilterUI("h ide-network-messages", WebInspector.UIString("Hide network messages"), true, Web Inspector.moduleSetting("hideNetworkMessages"));
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1412 return true; 1413 return true;
1413 } 1414 }
1414 return false; 1415 return false;
1415 } 1416 }
1416 } 1417 }
1417 1418
1418 /** 1419 /**
1419 * @typedef {{messageIndex: number, matchIndex: number}} 1420 * @typedef {{messageIndex: number, matchIndex: number}}
1420 */ 1421 */
1421 WebInspector.ConsoleView.RegexMatchRange; 1422 WebInspector.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698