Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/DockController.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 WebInspector.DockController.State = { 59 WebInspector.DockController.State = {
60 DockedToBottom: "bottom", 60 DockedToBottom: "bottom",
61 DockedToRight: "right", 61 DockedToRight: "right",
62 Undocked: "undocked" 62 Undocked: "undocked"
63 } 63 }
64 64
65 // Use BeforeDockSideChanged to do something before all the UI bits are updated, 65 // Use BeforeDockSideChanged to do something before all the UI bits are updated,
66 // DockSideChanged to update UI, and AfterDockSideChanged to perform actions 66 // DockSideChanged to update UI, and AfterDockSideChanged to perform actions
67 // after frontend is docked/undocked in the browser. 67 // after frontend is docked/undocked in the browser.
68
69 /** @enum {symbol} */
68 WebInspector.DockController.Events = { 70 WebInspector.DockController.Events = {
69 BeforeDockSideChanged: "BeforeDockSideChanged", 71 BeforeDockSideChanged: Symbol("BeforeDockSideChanged"),
70 DockSideChanged: "DockSideChanged", 72 DockSideChanged: Symbol("DockSideChanged"),
71 AfterDockSideChanged: "AfterDockSideChanged" 73 AfterDockSideChanged: Symbol("AfterDockSideChanged")
72 } 74 }
73 75
74 WebInspector.DockController.prototype = { 76 WebInspector.DockController.prototype = {
75 initialize: function() 77 initialize: function()
76 { 78 {
77 if (!this._canDock) 79 if (!this._canDock)
78 return; 80 return;
79 81
80 this._titles = [WebInspector.UIString("Dock to right"), WebInspector.UIS tring("Dock to bottom"), WebInspector.UIString("Undock into separate window")]; 82 this._titles = [WebInspector.UIString("Dock to right"), WebInspector.UIS tring("Dock to bottom"), WebInspector.UIString("Undock into separate window")];
81 this._dockSideChanged(); 83 this._dockSideChanged();
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 item: function() 225 item: function()
224 { 226 {
225 return WebInspector.dockController._closeButton; 227 return WebInspector.dockController._closeButton;
226 } 228 }
227 } 229 }
228 230
229 /** 231 /**
230 * @type {!WebInspector.DockController} 232 * @type {!WebInspector.DockController}
231 */ 233 */
232 WebInspector.dockController; 234 WebInspector.dockController;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698