Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/common/Console.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.Object} 7 * @extends {WebInspector.Object}
8 */ 8 */
9 WebInspector.Console = function() 9 WebInspector.Console = function()
10 { 10 {
11 /** @type {!Array.<!WebInspector.Console.Message>} */ 11 /** @type {!Array.<!WebInspector.Console.Message>} */
12 this._messages = []; 12 this._messages = [];
13 } 13 }
14 14
15 /** 15 /** @enum {symbol} */
16 * @enum {string}
17 */
18 WebInspector.Console.Events = { 16 WebInspector.Console.Events = {
19 MessageAdded: "messageAdded" 17 MessageAdded: Symbol("messageAdded")
20 } 18 }
21 19
22 /** 20 /**
23 * @enum {string} 21 * @enum {string}
24 */ 22 */
25 WebInspector.Console.MessageLevel = { 23 WebInspector.Console.MessageLevel = {
26 Log: "log", 24 Log: "log",
27 Warning: "warning", 25 Warning: "warning",
28 Error: "error" 26 Error: "error"
29 } 27 }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 */ 96 */
99 showPromise: function() 97 showPromise: function()
100 { 98 {
101 return WebInspector.Revealer.revealPromise(this); 99 return WebInspector.Revealer.revealPromise(this);
102 }, 100 },
103 101
104 __proto__: WebInspector.Object.prototype 102 __proto__: WebInspector.Object.prototype
105 } 103 }
106 104
107 WebInspector.console = new WebInspector.Console(); 105 WebInspector.console = new WebInspector.Console();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698