Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 this._breakpointsForUISourceCode = new Map(); 50 this._breakpointsForUISourceCode = new Map();
51 this._breakpointsForPrimaryUISourceCode = new Map(); 51 this._breakpointsForPrimaryUISourceCode = new Map();
52 /** @type {!Multimap.<string, !WebInspector.BreakpointManager.Breakpoint>} * / 52 /** @type {!Multimap.<string, !WebInspector.BreakpointManager.Breakpoint>} * /
53 this._provisionalBreakpoints = new Multimap(); 53 this._provisionalBreakpoints = new Multimap();
54 54
55 this._workspace.addEventListener(WebInspector.Workspace.Events.ProjectRemove d, this._projectRemoved, this); 55 this._workspace.addEventListener(WebInspector.Workspace.Events.ProjectRemove d, this._projectRemoved, this);
56 this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeA dded, this._uiSourceCodeAdded, this); 56 this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeA dded, this._uiSourceCodeAdded, this);
57 this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeR emoved, this._uiSourceCodeRemoved, this); 57 this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeR emoved, this._uiSourceCodeRemoved, this);
58 } 58 }
59 59
60 /** @enum {symbol} */
60 WebInspector.BreakpointManager.Events = { 61 WebInspector.BreakpointManager.Events = {
61 BreakpointAdded: "breakpoint-added", 62 BreakpointAdded: Symbol("breakpoint-added"),
62 BreakpointRemoved: "breakpoint-removed", 63 BreakpointRemoved: Symbol("breakpoint-removed"),
63 BreakpointsActiveStateChanged: "BreakpointsActiveStateChanged" 64 BreakpointsActiveStateChanged: Symbol("BreakpointsActiveStateChanged")
64 } 65 }
65 66
66 /** 67 /**
67 * @param {string} sourceFileId 68 * @param {string} sourceFileId
68 * @param {number} lineNumber 69 * @param {number} lineNumber
69 * @param {number} columnNumber 70 * @param {number} columnNumber
70 * @return {string} 71 * @return {string}
71 */ 72 */
72 WebInspector.BreakpointManager._breakpointStorageId = function(sourceFileId, lin eNumber, columnNumber) 73 WebInspector.BreakpointManager._breakpointStorageId = function(sourceFileId, lin eNumber, columnNumber)
73 { 74 {
(...skipping 1009 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 { 1084 {
1084 this.sourceFileId = breakpoint._sourceFileId; 1085 this.sourceFileId = breakpoint._sourceFileId;
1085 this.lineNumber = breakpoint.lineNumber(); 1086 this.lineNumber = breakpoint.lineNumber();
1086 this.columnNumber = breakpoint.columnNumber(); 1087 this.columnNumber = breakpoint.columnNumber();
1087 this.condition = breakpoint.condition(); 1088 this.condition = breakpoint.condition();
1088 this.enabled = breakpoint.enabled(); 1089 this.enabled = breakpoint.enabled();
1089 } 1090 }
1090 1091
1091 /** @type {!WebInspector.BreakpointManager} */ 1092 /** @type {!WebInspector.BreakpointManager} */
1092 WebInspector.breakpointManager; 1093 WebInspector.breakpointManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698