extensions/browser/extension_function_histogram_value.h - Issue 2261903002: Fix race condition in MD Settings Languages page causing inconsistent settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_histogram_value.h

Issue 2261903002: Fix race condition in MD Settings Languages page causing inconsistent settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: logging Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/settings/fake_language_settings_private.js ('k') | third_party/closure_compiler/externs/language_settings_private.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function_histogram_value.h

diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h

index b9f5a06fe973529323fca5105976d8427c8c1e4f..771a48d08bfbcd4589342444c671f92624d05984 100644

--- a/extensions/browser/extension_function_histogram_value.h

+++ b/extensions/browser/extension_function_histogram_value.h

@@ -1122,7 +1122,7 @@ enum HistogramValue {

FILEMANAGERPRIVATEINTERNAL_EXECUTECUSTOMACTION,

MDNS_FORCEDISCOVERY,

LANGUAGESETTINGSPRIVATE_GETLANGUAGELIST,

- LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST,

+ DELETED_LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST,

LANGUAGESETTINGSPRIVATE_GETSPELLCHECKDICTIONARYSTATUS,

LANGUAGESETTINGSPRIVATE_GETSPELLCHECKWORDS,

LANGUAGESETTINGSPRIVATE_GETTRANSLATETARGETLANGUAGE,

@@ -1203,6 +1203,8 @@ enum HistogramValue {

QUICKUNLOCKPRIVATE_GETAVAILABLEMODES,

WEBSTOREPRIVATE_ISPENDINGCUSTODIANAPPROVAL,

TABS_DISCARD,

+ LANGUAGESETTINGSPRIVATE_ENABLELANGUAGE,

+ LANGUAGESETTINGSPRIVATE_DISABLELANGUAGE,

// Last entry: Add new entries above, then run:

// python tools/metrics/histograms/update_extension_histograms.py

Ilya Sherman 2016/08/22 20:54:05 ^^^ Please run the script to update histograms.xml

michaelpg 2016/08/22 22:36:15 Rgh. Done. I don't know why I keep losing those ch

ENUM_BOUNDARY