Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2261893003: Remove GpuInfo::can_lose_context. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), enne (OOO), Ken Russell (switch to Gerrit), Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GpuInfo::can_lose_context. This was a legacy flag for WinXP which would lose context often during regular activities (like locking the screen). R=piman@chromium.org TBR=kenrb@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a08ad3d17ca44b954c1f2437451f4bbe834d89a2 Cr-Commit-Position: refs/heads/master@{#413566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -51 lines) Patch
M chrome/browser/gpu/gpu_driver_info_manager_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/fake_win_amd_gpu_info.py View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_info.h View 2 chunks +0 lines, -8 lines 0 comments Download
M gpu/config/gpu_info.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_info_collector_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M gpu/config/gpu_info_collector_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_info_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_info.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
danakj
4 years, 4 months ago (2016-08-20 01:31:32 UTC) #3
Ken Russell (switch to Gerrit)
Thank you for cleaning this up. LGTM for what it's worth (I don't think I'm ...
4 years, 4 months ago (2016-08-20 03:55:56 UTC) #6
piman
LGTM & thanks!
4 years, 4 months ago (2016-08-20 04:02:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261893003/1
4 years, 4 months ago (2016-08-22 18:07:24 UTC) #11
danakj
TBR=kenrb@chromium.org for gpu/ipc/common. Removing things from IPCs.
4 years, 4 months ago (2016-08-22 18:07:52 UTC) #13
kenrb
ipc lgtm
4 years, 4 months ago (2016-08-22 18:55:58 UTC) #15
Justin Novosad
\o/
4 years, 4 months ago (2016-08-22 19:43:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261893003/1
4 years, 4 months ago (2016-08-22 21:28:26 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 23:04:25 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:05:59 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a08ad3d17ca44b954c1f2437451f4bbe834d89a2
Cr-Commit-Position: refs/heads/master@{#413566}

Powered by Google App Engine
This is Rietveld 408576698