Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

Issue 2261853002: Changed Blimp IME to use PopUp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_popup
Patch Set: Used AlertDialog from support.v7 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
index 2b9b7f166d5318459114ab02fec7f00f7a4bcb44..ae60b5e1c561018f4f67a4363ae22f3f01a525b4 100644
--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
@@ -20,7 +20,7 @@ import org.chromium.blimp.auth.RetryingTokenSource;
import org.chromium.blimp.auth.TokenSource;
import org.chromium.blimp.auth.TokenSourceImpl;
import org.chromium.blimp.core.BlimpClientSwitches;
-import org.chromium.blimp.input.WebInputBox;
+import org.chromium.blimp.input.ImeHelperDialog;
import org.chromium.blimp.preferences.PreferencesUtil;
import org.chromium.blimp.session.BlimpClientSession;
import org.chromium.blimp.session.EngineInfo;
@@ -53,7 +53,7 @@ public class BlimpRendererActivity
private Toolbar mToolbar;
private BlimpClientSession mBlimpClientSession;
private TabControlFeature mTabControlFeature;
- private WebInputBox mWebInputBox;
+ private ImeHelperDialog mImeHelperDialog;
private Handler mHandler = new Handler();
@@ -102,9 +102,9 @@ public class BlimpRendererActivity
mToolbar = null;
}
- if (mWebInputBox != null) {
- mWebInputBox.destroy();
- mWebInputBox = null;
+ if (mImeHelperDialog != null) {
+ mImeHelperDialog.destroy();
+ mImeHelperDialog = null;
}
if (mTokenSource != null) {
@@ -167,8 +167,8 @@ public class BlimpRendererActivity
mToolbar = (Toolbar) findViewById(R.id.toolbar);
mToolbar.initialize(mBlimpClientSession, this);
- mWebInputBox = (WebInputBox) findViewById(R.id.editText);
- mWebInputBox.initialize(mBlimpClientSession);
+ mImeHelperDialog = new ImeHelperDialog(this);
+ mImeHelperDialog.initialize(mBlimpClientSession);
mTabControlFeature = new TabControlFeature(mBlimpClientSession, mBlimpView);

Powered by Google App Engine
This is Rietveld 408576698