src/core/SkTLList.h - Issue 226183018: SkNonCopyable should be used with private inheritance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkTLList.h

Issue 226183018: SkNonCopyable should be used with private inheritance. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: name resolution Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkTLList.h

diff --git a/src/core/SkTLList.h b/src/core/SkTLList.h

index aeae3f72eeb7f3c6b64be0f245e94c36b9ea2c1f..e2b9691430ac1757a71cc417a0f7113407a50907 100644

--- a/src/core/SkTLList.h

+++ b/src/core/SkTLList.h

@@ -28,7 +28,7 @@ inline void* operator new(size_t, SkTLList<T>* list,

constructor arguments for type_name. These macros behave like addBefore() and addAfter().

template <typename T>

-class SkTLList : public SkNoncopyable {

+class SkTLList : SkNoncopyable {

private:

struct Block;

struct Node {

« no previous file with comments | « src/core/SkSmallAllocator.h ('k') | src/gpu/GrAllocPool.h » ('j') | no next file with comments »