experimental/PdfViewer/inc/SkPdfRenderer.h - Issue 226183018: SkNonCopyable should be used with private inheritance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/inc/SkPdfRenderer.h

Issue 226183018: SkNonCopyable should be used with private inheritance. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: name resolution Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: experimental/PdfViewer/inc/SkPdfRenderer.h

diff --git a/experimental/PdfViewer/inc/SkPdfRenderer.h b/experimental/PdfViewer/inc/SkPdfRenderer.h

index c978a739eca353b824712d5ab0c3df6b4f4c9f9f..9fc1ff7c6b3b79f2bdb84875899bf719130d3606 100644

--- a/experimental/PdfViewer/inc/SkPdfRenderer.h

+++ b/experimental/PdfViewer/inc/SkPdfRenderer.h

@@ -29,7 +29,7 @@ enum SkPdfContent {

* The SkPdfRenderer class is used to render a PDF into canvas.

-class SkPdfRenderer : public SkNoncopyable {

+class SkPdfRenderer : SkNoncopyable {

public:

// Create a new renderer from a stream.

// TODO(edisonn): replace it with a SkSmartStream which would know to to efficiently

« no previous file with comments | « experimental/PdfViewer/inc/SkPdfContext.h ('k') | experimental/SkiaExamples/SkExample.h » ('j') | no next file with comments »