Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: include/core/SkRefCnt.h

Issue 226183018: SkNonCopyable should be used with private inheritance. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: name resolution Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/core/SkPicture.h ('k') | include/core/SkTInternalLList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2006 The Android Open Source Project 3 * Copyright 2006 The Android Open Source Project
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #ifndef SkRefCnt_DEFINED 10 #ifndef SkRefCnt_DEFINED
11 #define SkRefCnt_DEFINED 11 #define SkRefCnt_DEFINED
12 12
13 #include "SkDynamicAnnotations.h" 13 #include "SkDynamicAnnotations.h"
14 #include "SkThread.h" 14 #include "SkThread.h"
15 #include "SkInstCnt.h" 15 #include "SkInstCnt.h"
16 #include "SkTemplates.h" 16 #include "SkTemplates.h"
17 17
18 /** \class SkRefCntBase 18 /** \class SkRefCntBase
19 19
20 SkRefCntBase is the base class for objects that may be shared by multiple 20 SkRefCntBase is the base class for objects that may be shared by multiple
21 objects. When an existing owner wants to share a reference, it calls ref(). 21 objects. When an existing owner wants to share a reference, it calls ref().
22 When an owner wants to release its reference, it calls unref(). When the 22 When an owner wants to release its reference, it calls unref(). When the
23 shared object's reference count goes to zero as the result of an unref() 23 shared object's reference count goes to zero as the result of an unref()
24 call, its (virtual) destructor is called. It is an error for the 24 call, its (virtual) destructor is called. It is an error for the
25 destructor to be called explicitly (or via the object going out of scope on 25 destructor to be called explicitly (or via the object going out of scope on
26 the stack or calling delete) if getRefCnt() > 1. 26 the stack or calling delete) if getRefCnt() > 1.
27 */ 27 */
28 class SK_API SkRefCntBase : public SkNoncopyable { 28 class SK_API SkRefCntBase : SkNoncopyable {
29 public: 29 public:
30 SK_DECLARE_INST_COUNT_ROOT(SkRefCntBase) 30 SK_DECLARE_INST_COUNT_ROOT(SkRefCntBase)
31 31
32 /** Default construct, initializing the reference count to 1. 32 /** Default construct, initializing the reference count to 1.
33 */ 33 */
34 SkRefCntBase() : fRefCnt(1) {} 34 SkRefCntBase() : fRefCnt(1) {}
35 35
36 /** Destruct, asserting that the reference count is 1. 36 /** Destruct, asserting that the reference count is 1.
37 */ 37 */
38 virtual ~SkRefCntBase() { 38 virtual ~SkRefCntBase() {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 typedef T* SkRefPtr::*unspecified_bool_type; 283 typedef T* SkRefPtr::*unspecified_bool_type;
284 operator unspecified_bool_type() const { 284 operator unspecified_bool_type() const {
285 return fObj ? &SkRefPtr::fObj : NULL; 285 return fObj ? &SkRefPtr::fObj : NULL;
286 } 286 }
287 287
288 private: 288 private:
289 T* fObj; 289 T* fObj;
290 }; 290 };
291 291
292 #endif 292 #endif
OLDNEW
« no previous file with comments | « include/core/SkPicture.h ('k') | include/core/SkTInternalLList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698