Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 226183016: [MIPS] Make 'mips32' suffix for all test nexes (Closed)

Created:
6 years, 8 months ago by petarj
Modified:
6 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Make 'mips32' suffix for all test nexes Fix inconsistency between suffixes for MIPS test nexes. Now all test nexes for MIPS32 match *_mips32.nexe. NOTRY=true However, I have run a try job manually, and it passed fine, but CQ has some issues, and this is a workaround for it. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST=trybots Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=13000

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/untrusted.gypi View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
petarj
PTAL.
6 years, 8 months ago (2014-04-07 15:29:56 UTC) #1
jvoung (off chromium)
This is to sync up with the NMF listings? https://codereview.chromium.org/219193017/diff/1/ppapi/tests/ppapi_nacl_tests_newlib.nmf?column_width=80 LGTM
6 years, 8 months ago (2014-04-07 15:45:05 UTC) #2
petarj
On 2014/04/07 15:45:05, jvoung (cr) wrote: > This is to sync up with the NMF ...
6 years, 8 months ago (2014-04-07 16:21:52 UTC) #3
petarj
The CQ bit was checked by petarj@mips.com
6 years, 8 months ago (2014-04-07 16:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/226183016/1
6 years, 8 months ago (2014-04-07 16:23:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 16:24:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.nacl on nacl-precise_64-newlib-mips-pnacl tryserver.nacl on nacl-precise_64-newlib-x86_32-pnacl-spec
6 years, 8 months ago (2014-04-07 16:24:05 UTC) #7
petarj
The CQ bit was checked by petarj@mips.com
6 years, 8 months ago (2014-04-07 16:44:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/226183016/20001
6 years, 8 months ago (2014-04-07 16:44:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 16:45:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.nacl on nacl-precise_64-newlib-mips-pnacl
6 years, 8 months ago (2014-04-07 16:45:25 UTC) #11
petarj
The CQ bit was checked by petarj@mips.com
6 years, 8 months ago (2014-04-07 16:57:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/226183016/20001
6 years, 8 months ago (2014-04-07 16:57:35 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 16:57:46 UTC) #14
Message was sent while issue was closed.
Change committed as 13000

Powered by Google App Engine
This is Rietveld 408576698