Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 226183015: Added HTTP response code field to ResourceRequestDetails. (Closed)

Created:
6 years, 8 months ago by pdamek
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added HTTP response code field to ResourceRequestDetails. BUG=361585 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262987

Patch Set 1 #

Total comments: 4

Patch Set 2 : Corrections after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/public/browser/resource_request_details.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/resource_request_details.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pdamek
6 years, 8 months ago (2014-04-07 13:16:12 UTC) #1
Charlie Reis
I'll defer to Darin, but it seems like the response code is something that should ...
6 years, 8 months ago (2014-04-07 16:17:44 UTC) #2
Charlie Reis
Also, please try to include some information in the CL for why you need this. ...
6 years, 8 months ago (2014-04-07 16:20:38 UTC) #3
pdamek
Well, this change is used by some Opera's client code, so actually I can't point ...
6 years, 8 months ago (2014-04-08 11:33:47 UTC) #4
Charlie Reis
Darin's out this week, so I'll add mmenke for his thoughts. On 2014/04/08 11:33:47, pdamek ...
6 years, 8 months ago (2014-04-08 19:58:05 UTC) #5
mmenke
On 2014/04/08 19:58:05, Charlie Reis wrote: > Darin's out this week, so I'll add mmenke ...
6 years, 8 months ago (2014-04-08 20:44:59 UTC) #6
Charlie Reis
Huh, ok. I don't know this API well enough to say, so I'll defer to ...
6 years, 8 months ago (2014-04-08 23:22:29 UTC) #7
mmenke
Ahh...I missed that LoadCommittedDetails already includes http status code for frames. pdamek: I assume you ...
6 years, 8 months ago (2014-04-09 14:52:56 UTC) #8
pdamek
On 2014/04/09 14:52:56, mmenke wrote: > Ahh...I missed that LoadCommittedDetails already includes http status code ...
6 years, 8 months ago (2014-04-09 16:11:33 UTC) #9
mmenke
On 2014/04/09 16:11:33, pdamek wrote: > On 2014/04/09 14:52:56, mmenke wrote: > > Ahh...I missed ...
6 years, 8 months ago (2014-04-09 16:17:14 UTC) #10
pdamek
> On 2014/04/09 14:52:56, mmenke wrote: > > Ahh...I missed that LoadCommittedDetails already includes http ...
6 years, 8 months ago (2014-04-09 16:31:12 UTC) #11
Charlie Reis
Thanks. LGTM.
6 years, 8 months ago (2014-04-09 20:05:26 UTC) #12
pdamek
The CQ bit was checked by pdamek@opera.com
6 years, 8 months ago (2014-04-10 12:29:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdamek@opera.com/226183015/20001
6 years, 8 months ago (2014-04-10 12:29:56 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 14:39:51 UTC) #15
Message was sent while issue was closed.
Change committed as 262987

Powered by Google App Engine
This is Rietveld 408576698