Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 226183002: Prevent potential leaking of memory by using SkString and SkTArray. (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Prevent potential leaking of memory by using SkString and SkTArray. Committed: http://code.google.com/p/skia/source/detail?r=14064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M src/ports/SkFontConfigInterface_android.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/ports/SkFontConfigParser_android.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/ports/SkFontConfigParser_android.cpp View 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
djsollen
See https://android-review.googlesource.com/#/c/90061/ for the inspiration for this CL.
6 years, 8 months ago (2014-04-04 15:47:20 UTC) #1
djsollen
6 years, 8 months ago (2014-04-04 16:01:49 UTC) #2
mtklein
lgtm
6 years, 8 months ago (2014-04-04 16:05:02 UTC) #3
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 8 months ago (2014-04-04 17:13:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/226183002/1
6 years, 8 months ago (2014-04-04 17:13:14 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 18:14:56 UTC) #6
Message was sent while issue was closed.
Change committed as 14064

Powered by Google App Engine
This is Rietveld 408576698