Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2261803002: [MD settings] list-button class shows actionable style mouse (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] list-button class shows actionable style mouse This CL changes list-button rows to be 'actionable'. That means that a hand mouse cursor is shown rather than an I-beam mouse cursor when the mouse is over the button. BUG=635819 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/51071f55a9c5b147ec42660c1e27416098ec8cb8 Cr-Commit-Position: refs/heads/master@{#413472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 4 months ago (2016-08-19 21:29:11 UTC) #4
Finnur
LGTM
4 years, 4 months ago (2016-08-22 10:54:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261803002/1
4 years, 4 months ago (2016-08-22 16:57:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 17:57:02 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:58:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51071f55a9c5b147ec42660c1e27416098ec8cb8
Cr-Commit-Position: refs/heads/master@{#413472}

Powered by Google App Engine
This is Rietveld 408576698