Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Address second wave of comments, turn off feedback in non-Chrome builds Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index fb9037b503330289916dfb4956ee1dac297a8504..76181e3132221f97c6ea4a7ffb9d61ecd9a7fb31 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -61529,6 +61529,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Tabs.SadTab.Feedback.Event" enum="SadTabEvent">
+ <owner>sdy@chromium.org</owner>
+ <summary>
+ Counts of events from the style of sad tab which has a feedback button as
+ its primary action. Currently, events include being displayed (actually
+ visible in a window), and the actions a user can take on the page.
+ </summary>
+</histogram>
+
<histogram name="Tabs.SadTab.KillCreated" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
@@ -61602,6 +61611,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Tabs.SadTab.Reload.Event" enum="SadTabEvent">
+ <owner>sdy@chromium.org</owner>
+ <summary>
+ Counts of events from the style of sad tab which has a reload button as its
+ primary action. Compare to Tabs.SadTab.Feedback.Event.
+ </summary>
+</histogram>
+
<histogram name="Tabs.SadTab.ReloadCount" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
@@ -92586,6 +92603,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Tabbed Mode"/>
</enum>
+<enum name="SadTabEvent" type="int">
+ <int value="0" label="Displayed"/>
+ <int value="1" label="Button clicked"/>
+ <int value="2" label="Learn more clicked"/>
+</enum>
+
<enum name="SadTabKind" type="int">
<int value="0" label="Crash (Aw, Snap!)"/>
<int value="1" label="Kill (He's dead, Jim!)"/>
« no previous file with comments | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698