Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2848)

Unified Diff: chrome/browser/ui/views/sad_tab_view.h

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Address second wave of comments, turn off feedback in non-Chrome builds Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.cc ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/sad_tab_view.h
diff --git a/chrome/browser/ui/views/sad_tab_view.h b/chrome/browser/ui/views/sad_tab_view.h
index f5d07845053d22cb5db156b75191663e0d26d057..2c18287ad06a9ef1d489c5efc89e3de4e4084baa 100644
--- a/chrome/browser/ui/views/sad_tab_view.h
+++ b/chrome/browser/ui/views/sad_tab_view.h
@@ -5,8 +5,6 @@
#ifndef CHROME_BROWSER_UI_VIEWS_SAD_TAB_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_SAD_TAB_VIEW_H_
-#include "base/compiler_specific.h"
-#include "base/macros.h"
#include "chrome/browser/ui/sad_tab.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/link_listener.h"
@@ -36,12 +34,6 @@ class SadTabView : public chrome::SadTab,
public views::LinkListener,
public views::ButtonListener {
public:
- // Tag to denote which type of action button is displayed.
- enum ButtonTag {
- SAD_TAB_BUTTON_FEEDBACK,
- SAD_TAB_BUTTON_RELOAD,
- };
-
SadTabView(content::WebContents* web_contents, chrome::SadTabKind kind);
~SadTabView() override;
@@ -59,24 +51,15 @@ class SadTabView : public chrome::SadTab,
void OnPaint(gfx::Canvas* canvas) override;
private:
- // Overridden from chrome::SadTab:
- void Show() override;
- void Close() override;
views::Label* CreateLabel(const base::string16& text);
views::Link* CreateLink(const base::string16& text, const SkColor& color);
- content::WebContents* web_contents_;
- chrome::SadTabKind kind_;
- bool painted_;
+ bool painted_ = false;
views::Label* message_;
views::Link* help_link_;
views::LabelButton* action_button_;
views::Label* title_;
- views::StyledLabel* help_message_;
- static int total_crashes_;
-
- DISALLOW_COPY_AND_ASSIGN(SadTabView);
};
#endif // CHROME_BROWSER_UI_VIEWS_SAD_TAB_VIEW_H__
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.cc ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698