chrome/browser/ui/BUILD.gn - Issue 2261793002: Bring the feedback button to the Mac sad tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Address second wave of comments, turn off feedback in non-Chrome builds Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 4334640268a7f7f79f1eb271f48efae9cebe504a..d216919574d0875dabe1a720a647db946f2c773e 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -2260,8 +2260,7 @@ split_static_library("ui") {

"cocoa/status_icons/status_tray_mac.mm",

"cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h",

"cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm",

- "cocoa/tab_contents/sad_tab_controller.h",

- "cocoa/tab_contents/sad_tab_controller.mm",

+ "cocoa/tab_contents/sad_tab_mac.mm",

"cocoa/tab_contents/sad_tab_view_cocoa.h",

"cocoa/tab_contents/sad_tab_view_cocoa.mm",

"cocoa/tab_contents/web_drag_bookmark_handler_mac.h",

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h » ('j') | no next file with comments »