chrome/browser/ui/sad_tab_helper.cc - Issue 2261793002: Bring the feedback button to the Mac sad tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_helper.cc

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Ditch a pointless |explicit|, add a comment on SadTabView ownership. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sad_tab_helper.cc

diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc

index bc409bcd051b6945fae9b17589a88b1d3006eb83..2e502d7fe2f983a1c74cc977a3aa8b2069f22b0d 100644

--- a/chrome/browser/ui/sad_tab_helper.cc

+++ b/chrome/browser/ui/sad_tab_helper.cc

@@ -41,10 +41,7 @@ SadTabHelper::SadTabHelper(content::WebContents* web_contents)

}

void SadTabHelper::RenderViewReady() {

- if (sad_tab_) {

- sad_tab_->Close();

- sad_tab_.reset();

- }

+ sad_tab_.reset();

}

void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {

@@ -64,5 +61,4 @@ void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {

void SadTabHelper::InstallSadTab(base::TerminationStatus status) {

sad_tab_.reset(chrome::SadTab::Create(

web_contents(), SadTabKindFromTerminationStatus(status)));

- sad_tab_->Show();

}