Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Ditch a pointless |explicit|, add a comment on SadTabView ownership. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
index bbaf5906ae76bb4d07bf225cc6bdbf11866854c7..c9378ef5e89cbf4ecc56fba57365ce9035c06f1f 100644
--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
@@ -7,25 +7,12 @@
#import <Cocoa/Cocoa.h>
-#import "ui/base/cocoa/controls/hyperlink_text_view.h"
-
-@class SadTabView;
-
-@protocol SadTabViewDelegate
-- (void)sadTabViewButtonClicked:(SadTabView*)sadTabView;
-- (void)sadTabView:(SadTabView*)sadTabView
- helpLinkClickedWithURL:(NSString*)url;
-@end
+#include "chrome/browser/ui/sad_tab.h"
// A view that displays the "sad tab" (aka crash page).
@interface SadTabView : NSView
-@property(nonatomic, assign) id<SadTabViewDelegate> delegate;
-
-- (void)setTitle:(int)title;
-- (void)setMessage:(int)message;
-- (void)setButtonTitle:(int)buttonTitle;
-- (void)setHelpLinkTitle:(int)helpLinkTitle URL:(NSString*)url;
+- (instancetype)initWithFrame:(NSRect)frame sadTab:(chrome::SadTab*)sadTab;
@end

Powered by Google App Engine
This is Rietveld 408576698