Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5701)

Unified Diff: chrome/browser/ui/sad_tab_helper.cc

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: CL cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sad_tab_helper.cc
diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc
index bc409bcd051b6945fae9b17589a88b1d3006eb83..2e502d7fe2f983a1c74cc977a3aa8b2069f22b0d 100644
--- a/chrome/browser/ui/sad_tab_helper.cc
+++ b/chrome/browser/ui/sad_tab_helper.cc
@@ -41,10 +41,7 @@ SadTabHelper::SadTabHelper(content::WebContents* web_contents)
}
void SadTabHelper::RenderViewReady() {
- if (sad_tab_) {
- sad_tab_->Close();
- sad_tab_.reset();
- }
+ sad_tab_.reset();
}
void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {
@@ -64,5 +61,4 @@ void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {
void SadTabHelper::InstallSadTab(base::TerminationStatus status) {
sad_tab_.reset(chrome::SadTab::Create(
web_contents(), SadTabKindFromTerminationStatus(status)));
- sad_tab_->Show();
}

Powered by Google App Engine
This is Rietveld 408576698