Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/ui/sad_tab.h

Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Address second wave of comments, turn off feedback in non-Chrome builds Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SAD_TAB_H_ 5 #ifndef CHROME_BROWSER_UI_SAD_TAB_H_
6 #define CHROME_BROWSER_UI_SAD_TAB_H_ 6 #define CHROME_BROWSER_UI_SAD_TAB_H_
7 7
8 #include "base/process/kill.h" 8 #include "base/process/kill.h"
9 #include "chrome/browser/ui/sad_tab_types.h" 9 #include "chrome/browser/ui/sad_tab_types.h"
10 10
11 namespace content { 11 namespace content {
12 class WebContents; 12 class WebContents;
13 } 13 }
14 14
15 namespace chrome { 15 namespace chrome {
16 16
17 // Cross-platform interface to show the Sad tab UI. 17 // Cross-platform interface to show the Sad tab UI.
18 class SadTab { 18 class SadTab {
19 public: 19 public:
20 enum class Action {
21 BUTTON,
22 HELP_LINK,
23 };
24
20 // Factory function to create the platform specific implementations. 25 // Factory function to create the platform specific implementations.
21 static SadTab* Create(content::WebContents* web_contents, SadTabKind kind); 26 static SadTab* Create(content::WebContents* web_contents, SadTabKind kind);
22 27
23 // Returns true if the sad tab should be shown. 28 // Returns true if the sad tab should be shown.
24 static bool ShouldShow(base::TerminationStatus status); 29 static bool ShouldShow(base::TerminationStatus status);
25 30
26 virtual ~SadTab() {} 31 virtual ~SadTab() {}
27 32
28 // Shows the Sad tab. 33 // These functions return resource string IDs for UI text. They may be
29 virtual void Show() = 0; 34 // different for each sad tab. (Right now, the first sad tab in a session
35 // suggests reloading and subsequent ones suggest sending feedback.)
36 int GetTitle();
37 int GetMessage();
38 int GetButtonTitle();
39 int GetHelpLinkTitle();
30 40
31 // Closes the Sad tab. 41 // Returns the target of the "Learn more" link. Use it for the context menu
32 virtual void Close() = 0; 42 // and to show the URL on hover, but call PerformAction() for regular clicks.
43 const char* GetHelpLinkURL();
44
45 // Virtual for testing.
46 virtual void RecordFirstPaint();
47 virtual void PerformAction(Action);
48
49 protected:
50 SadTab(content::WebContents* web_contents, SadTabKind kind);
51
52 private:
53 content::WebContents* web_contents_;
54 SadTabKind kind_;
55 bool show_feedback_button_;
56 bool recorded_paint_;
57
58 DISALLOW_COPY_AND_ASSIGN(SadTab);
33 }; 59 };
34 60
35 } // namespace chrome 61 } // namespace chrome
36 62
37 #endif // CHROME_BROWSER_UI_SAD_TAB_H_ 63 #endif // CHROME_BROWSER_UI_SAD_TAB_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa_unittest.mm ('k') | chrome/browser/ui/sad_tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698