Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2261793002: Bring the feedback button to the Mac sad tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Trybots caught this, but not the local presubmit check. Will investigate. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/ui/sad_tab.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 258c01d17d5ca3dc5dc3fc6479deb91ac7ac62d2..b118fccb5bb6055585bf75ffe073ea1c46ce26a4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -61421,6 +61421,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Tabs.SadTab.StyleFeedback" enum="SadTabEvent">
+ <owner>sdy@chromium.org</owner>
+ <summary>
+ Counts of events from the style of sad tab which has a feedback button as
+ its primary action. Currently, events include being displayed (actually
+ visible in a window), and the actions a user can take on the page.
+ </summary>
+</histogram>
+
+<histogram name="Tabs.SadTab.StyleReload" enum="SadTabEvent">
+ <owner>sdy@chromium.org</owner>
+ <summary>
+ Counts of events from the style of sad tab which has a reload button as its
+ primary action. Compare to Tabs.SadTab.StyleFeedback.
+ </summary>
+</histogram>
+
<histogram name="Tabs.ScrubDistance" units="tabs">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
@@ -92255,6 +92272,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Tabbed Mode"/>
</enum>
+<enum name="SadTabEvent" type="int">
+ <int value="0" label="Displayed"/>
+ <int value="1" label="Button clicked"/>
+ <int value="2" label="Learn more clicked"/>
+</enum>
+
<enum name="SadTabKind" type="int">
<int value="0" label="Crash (Aw, Snap!)"/>
<int value="1" label="Kill (He's dead, Jim!)"/>
« chrome/browser/ui/sad_tab.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698