Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html

Issue 2261733002: [css-grid] Only force full invalidation when grid item data change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch rebased. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
diff --git a/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html b/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
index f15b1705e02efe2b5b14045023f6481c41266a71..18caabc17d5956521ad29b498f361a3beb88720e 100644
--- a/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
+++ b/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
@@ -3,7 +3,8 @@
<script>
function repaintTest() {
document.getElementsByClassName('item1')[0].style.alignSelf = 'stretch';
- document.getElementsByClassName('item2')[0].style.alignSelf = 'stretch';
+ document.getElementsByClassName('item2')[0].style.alignSelf = 'end';
+ document.getElementsByClassName('item3')[0].style.alignSelf = 'start';
}
onload = runRepaintAndPixelTest;
</script>
@@ -22,18 +23,31 @@ body {
.item1 {
grid-row: 1;
grid-column: 1;
- height: 300px;
background-color: green;
+ width: 100px;
}
.item2 {
grid-row: 1;
grid-column: 2;
+ align-self: start;
+ background-color: green;
height: 300px;
+ width: 100px;
+}
+.item3 {
+ grid-row: 1;
+ grid-column: 2;
+ align-self: end;
background-color: green;
+ height: 300px;
+ width: 100px;
}
</style>
<p style="height: 20px">There should be no invalidations because align-self style change causes no visual change.</p>
<div id="container">
- <div id="item1" class="item1"></div>
- <div id="item2" class="item2"></div>
+ <div class="item1">
+ <div style="height: 300px;"></div>
+ </div>
+ <div class="item2"></div>
+ <div class="item3"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698