third_party/WebKit/Source/web/WebInputEventConversion.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputEventConversion.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/RotationViewportAnchor.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebInputEventConversion.cpp

diff --git a/third_party/WebKit/Source/web/WebInputEventConversion.cpp b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

index 203d818402322973f8c285b1fa1c923fd1ab3134..2f88073d92c6ca0906a58e8767dcd8019e277ce8 100644

--- a/third_party/WebKit/Source/web/WebInputEventConversion.cpp

+++ b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

@@ -511,7 +511,7 @@ static void updateWebMouseEventFromCoreMouseEvent(const MouseRelatedEvent& event

FrameView* view = widget ? toFrameView(widget->parent()) : 0;

// TODO(bokan): If view == nullptr, pointInRootFrame will really be pointInRootContent.

- IntPoint pointInRootFrame = IntPoint(event.absoluteLocation().x(), event.absoluteLocation().y());

+ IntPoint pointInRootFrame = IntPoint(event.absoluteLocation().x().toInt(), event.absoluteLocation().y().toInt());

if (view)

pointInRootFrame = view->contentsToRootFrame(pointInRootFrame);

webEvent.globalX = event.screenX();