third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

diff --git a/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp b/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

index 2980a044f67b6ca7012a3d99efd0dfacf941c165..5b75055387a9139aa14e4d8b02b8588c6bfaeea7 100644

--- a/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

+++ b/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp

@@ -19,12 +19,12 @@ static int computeEdgeWidth(const BorderImageLength& borderSlice, int borderSide

return borderSlice.number() * borderSide;

if (borderSlice.length().isAuto())

return imageSide;

- return valueForLength(borderSlice.length(), LayoutUnit(boxExtent));

+ return valueForLength(borderSlice.length(), LayoutUnit(boxExtent)).toInt();

}

static int computeEdgeSlice(const Length& slice, int maximum)

{

- return std::min<int>(maximum, valueForLength(slice, LayoutUnit(maximum)));

+ return std::min<int>(maximum, valueForLength(slice, LayoutUnit(maximum)).toInt());

}

NinePieceImageGrid::NinePieceImageGrid(const NinePieceImage& ninePieceImage, IntSize imageSize, IntRect borderImageArea,