third_party/WebKit/Source/core/page/SpatialNavigation.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/FocusController.cpp ('k') | third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

diff --git a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

index 52c1a5b4674369b304d0d63f7a446d859a596f30..ac287f78df832b9dd1af804a633af619106d17ef 100644

--- a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

+++ b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

@@ -555,14 +555,14 @@ void distanceDataForNode(WebFocusType type, const FocusCandidate& current, Focus

case WebFocusTypeRight:

navigationAxisDistance = xAxis;

if (!rectsIntersectOnOrthogonalAxis(type, currentRect, nodeRect))

- orthogonalBias = currentRect.height() / 2;

+ orthogonalBias = (currentRect.height() / 2).toInt();

weightedOrthogonalAxisDistance = (yAxis + orthogonalBias) * orthogonalWeightForLeftRight;

break;

case WebFocusTypeUp:

case WebFocusTypeDown:

navigationAxisDistance = yAxis;

if (!rectsIntersectOnOrthogonalAxis(type, currentRect, nodeRect))

- orthogonalBias = currentRect.width() / 2;

+ orthogonalBias = (currentRect.width() / 2).toInt();

weightedOrthogonalAxisDistance = (xAxis + orthogonalBias) * orthogonalWeightForUpDown;

break;

default: