third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp b/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp

index a4a1cc3beaec604c1c7a0bf4d057d05c79045160..c99355f452f685da7ba5c5e09271ca10fd08e692 100644

--- a/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp

@@ -157,8 +157,8 @@ LineSegment RasterShape::getExcludedInterval(LayoutUnit logicalTop, LayoutUnit l

if (intervals.isEmpty())

return LineSegment();

- int y1 = logicalTop;

- int y2 = logicalTop + logicalHeight;

+ int y1 = logicalTop.toInt();

+ int y2 = (logicalTop + logicalHeight).toInt();

ASSERT(y2 >= y1);

if (y2 < intervals.bounds().y() || y1 >= intervals.bounds().maxY())

return LineSegment();