third_party/WebKit/Source/core/layout/line/InlineBox.h - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/EllipsisBox.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h

index 40d75eb10c8285bd1c2b218b66830a5e6661d4b4..02f7e63b1905fccf9ad96722a237614fedd1779a 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h

@@ -211,9 +211,9 @@ public:

else

setY(left);

}

- int pixelSnappedLogicalLeft() const { return logicalLeft(); }

+ int pixelSnappedLogicalLeft() const { return logicalLeft().toInt(); }

int pixelSnappedLogicalRight() const { return logicalRight().ceil(); }

- int pixelSnappedLogicalTop() const { return logicalTop(); }

+ int pixelSnappedLogicalTop() const { return logicalTop().toInt(); }

int pixelSnappedLogicalBottom() const { return logicalBottom().ceil(); }

// The logicalTop[ position is the top edge of the line box in a horizontal line and the left edge in a vertical line.