third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

index fa86b988f4cf43a6f956574323cbeede92209353..f4f03f0d8391e071a917159bc1499b6b5d7abc7b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

@@ -455,8 +455,8 @@ static void writeTextRun(TextStream& ts, const LayoutText& o, const InlineTextBo

{

// FIXME: For now use an "enclosingIntRect" model for x, y and logicalWidth, although this makes it harder

// to detect any changes caused by the conversion to floating point. :(

- int x = run.x();

- int y = run.y();

+ int x = run.x().toInt();

+ int y = run.y().toInt();

int logicalWidth = (run.left() + run.logicalWidth()).ceil() - x;

// FIXME: Table cell adjustment is temporary until results can be updated.

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp » ('j') | no next file with comments »