third_party/WebKit/Source/core/layout/LayoutTable.h - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutSlider.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTable.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h

index c0c476ed5968397ff222f82b0a9ae977eeb82fc6..724faa11702be3ccb8906ff964c525dc045d2c64 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h

@@ -299,8 +299,8 @@ public:

LayoutUnit paddingRight() const override;

// Override paddingStart/End to return pixel values to match behavor of LayoutTableCell.

- LayoutUnit paddingEnd() const override { return LayoutUnit(static_cast<int>(LayoutBlock::paddingEnd())); }

- LayoutUnit paddingStart() const override { return LayoutUnit(static_cast<int>(LayoutBlock::paddingStart())); }

+ LayoutUnit paddingEnd() const override { return LayoutUnit(LayoutBlock::paddingEnd().toInt()); }

+ LayoutUnit paddingStart() const override { return LayoutUnit(LayoutBlock::paddingStart().toInt()); }

LayoutUnit bordersPaddingAndSpacingInRowDirection() const

{

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutSlider.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »