third_party/WebKit/Source/core/layout/LayoutListMarker.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutInline.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

index 144904feb395a46ec30114443a9bcb9b5165a966..60c1d193213d629516d63b3b29035b1bfd14aebd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

@@ -422,13 +422,13 @@ IntRect LayoutListMarker::getRelativeMarkerRect() const

}

break;

case ListStyleCategory::Language:

- relativeRect = IntRect(0, 0, getWidthOfTextWithSuffix(), style()->font().getFontMetrics().height());

+ relativeRect = IntRect(0, 0, getWidthOfTextWithSuffix().toInt(), style()->font().getFontMetrics().height());

break;

}

if (!style()->isHorizontalWritingMode()) {

relativeRect = relativeRect.transposedRect();

- relativeRect.setX(size().width() - relativeRect.x() - relativeRect.width());

+ relativeRect.setX((size().width() - relativeRect.x() - relativeRect.width()).toInt());

}

return relativeRect;