third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp b/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

index 6f88d569750ec58d1995028f74b1dbc5177b4b73..b797e964cc0dddaad764f149978ce32417945b07 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp

@@ -375,8 +375,8 @@ void LayoutFrameSet::layout()

}

LayoutUnit borderThickness(frameSet()->border());

- layOutAxis(m_rows, frameSet()->rowLengths(), size().height() - (rows - 1) * borderThickness);

- layOutAxis(m_cols, frameSet()->colLengths(), size().width() - (cols - 1) * borderThickness);

+ layOutAxis(m_rows, frameSet()->rowLengths(), (size().height() - (rows - 1) * borderThickness).toInt());

+ layOutAxis(m_cols, frameSet()->colLengths(), (size().width() - (cols - 1) * borderThickness).toInt());

positionFrames();