Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Side by Side Diff: third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. 2 * Copyright (C) 2007 Apple Inc.
3 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 3 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
4 * Copyright (C) 2008 Collabora Ltd. 4 * Copyright (C) 2008 Collabora Ltd.
5 * Copyright (C) 2008, 2009 Google Inc. 5 * Copyright (C) 2008, 2009 Google Inc.
6 * Copyright (C) 2009 Kenneth Rohde Christiansen 6 * Copyright (C) 2009 Kenneth Rohde Christiansen
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 255
256 void ThemePainterDefault::setupMenuListArrow(const LayoutBox& box, const IntRect & rect, WebThemeEngine::ExtraParams& extraParams) 256 void ThemePainterDefault::setupMenuListArrow(const LayoutBox& box, const IntRect & rect, WebThemeEngine::ExtraParams& extraParams)
257 { 257 {
258 const int right = rect.x() + rect.width(); 258 const int right = rect.x() + rect.width();
259 const int middle = rect.y() + rect.height() / 2; 259 const int middle = rect.y() + rect.height() / 2;
260 260
261 extraParams.menuList.arrowY = middle; 261 extraParams.menuList.arrowY = middle;
262 if (useMockTheme()) { 262 if (useMockTheme()) {
263 // The size and position of the drop-down button is different between 263 // The size and position of the drop-down button is different between
264 // the mock theme and the regular aura theme. 264 // the mock theme and the regular aura theme.
265 int spacingTop = box.borderTop() + box.paddingTop(); 265 int spacingTop = (box.borderTop() + box.paddingTop()).toInt();
266 int spacingBottom = box.borderBottom() + box.paddingBottom(); 266 int spacingBottom = (box.borderBottom() + box.paddingBottom()).toInt();
267 int spacingRight = box.borderRight() + box.paddingRight(); 267 int spacingRight = (box.borderRight() + box.paddingRight()).toInt();
268 extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) ? rect .x() + 4 + spacingRight: right - 10 - spacingRight; 268 extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) ? rect .x() + 4 + spacingRight: right - 10 - spacingRight;
269 extraParams.menuList.arrowSize = rect.height() - spacingBottom - spacing Top; 269 extraParams.menuList.arrowSize = rect.height() - spacingBottom - spacing Top;
270 } else { 270 } else {
271 const int arrowSize = 6; 271 const int arrowSize = 6;
272 const int arrowPadding = 6; 272 const int arrowPadding = 6;
273 extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) 273 extraParams.menuList.arrowX = (box.styleRef().direction() == RTL)
274 ? rect.x() + arrowPadding * box.styleRef().effectiveZoom() + box.bor derLeft() 274 ? rect.x() + arrowPadding * box.styleRef().effectiveZoom() + box.bor derLeft()
275 : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom( ) - box.borderRight(); 275 : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom( ) - box.borderRight();
276 extraParams.menuList.arrowSize = arrowSize * box.styleRef().effectiveZoo m(); 276 extraParams.menuList.arrowSize = arrowSize * box.styleRef().effectiveZoo m();
277 } 277 }
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 cancelButtonSize, cancelButtonSize); 392 cancelButtonSize, cancelButtonSize);
393 IntRect paintingRect = convertToPaintingRect(inputLayoutBox, cancelButtonObj ect, cancelButtonRect, r); 393 IntRect paintingRect = convertToPaintingRect(inputLayoutBox, cancelButtonObj ect, cancelButtonRect, r);
394 394
395 DEFINE_STATIC_REF(Image, cancelImage, (Image::loadPlatformResource("searchCa ncel"))); 395 DEFINE_STATIC_REF(Image, cancelImage, (Image::loadPlatformResource("searchCa ncel")));
396 DEFINE_STATIC_REF(Image, cancelPressedImage, (Image::loadPlatformResource("s earchCancelPressed"))); 396 DEFINE_STATIC_REF(Image, cancelPressedImage, (Image::loadPlatformResource("s earchCancelPressed")));
397 paintInfo.context.drawImage(LayoutTheme::isPressed(cancelButtonObject) ? can celPressedImage : cancelImage, paintingRect); 397 paintInfo.context.drawImage(LayoutTheme::isPressed(cancelButtonObject) ? can celPressedImage : cancelImage, paintingRect);
398 return false; 398 return false;
399 } 399 }
400 400
401 } // namespace blink 401 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/TableSectionPainter.cpp ('k') | third_party/WebKit/Source/core/paint/ViewPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698