Disallow cast/implicit conversion from LayoutUnit to int/unsigned

third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

 /*
  * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 169 matching lines @@
     if (destroy)
         return;
 
     // See if the scrollbar's thickness changed.  If so, we need to mark our owning object as needing a layout.
     bool isHorizontal = orientation() == HorizontalScrollbar;
     int oldThickness = isHorizontal ? height() : width();
     int newThickness = 0;
     LayoutScrollbarPart* part = m_parts.get(ScrollbarBGPart);
     if (part) {
         part->layout();
-        newThickness = isHorizontal ? part->size().height() : part->size().width();
+        newThickness = (isHorizontal ? part->size().height() : part->size().width()).toInt();
     }
 
     if (newThickness != oldThickness) {
         setFrameRect(IntRect(location(), IntSize(isHorizontal ? width() : newThickness, isHorizontal ? newThickness : height())));
         if (LayoutBox* box = owningLayoutObjectWithinFrame()) {
             if (box->isLayoutBlock())
                 toLayoutBlock(box)->notifyScrollbarThicknessChanged();
             box->setChildNeedsLayout();
             if (m_scrollableArea)
                 m_scrollableArea->setScrollCornerNeedsPaintInvalidation();
@@ skipping 105 matching lines @@
         isHorizontal ? height() : partLayoutObject->pixelSnappedHeight());
 }
 
 IntRect LayoutScrollbar::trackRect(int startLength, int endLength) const
 {
     LayoutScrollbarPart* part = m_parts.get(TrackBGPart);
     if (part)
         part->layout();
 
     if (orientation() == HorizontalScrollbar) {
-        int marginLeft = part ? static_cast<int>(part->marginLeft()) : 0;
-        int marginRight = part ? static_cast<int>(part->marginRight()) : 0;
+        int marginLeft = part ? part->marginLeft().toInt() : 0;
+        int marginRight = part ? part->marginRight().toInt() : 0;
         startLength += marginLeft;
         endLength += marginRight;
         int totalLength = startLength + endLength;
         return IntRect(x() + startLength, y(), width() - totalLength, height());
     }
 
-    int marginTop = part ? static_cast<int>(part->marginTop()) : 0;
-    int marginBottom = part ? static_cast<int>(part->marginBottom()) : 0;
+    int marginTop = part ? part->marginTop().toInt() : 0;
+    int marginBottom = part ? part->marginBottom().toInt() : 0;
     startLength += marginTop;
     endLength += marginBottom;
     int totalLength = startLength + endLength;
 
     return IntRect(x(), y() + startLength, width(), height() - totalLength);
 }
 
 IntRect LayoutScrollbar::trackPieceRectWithMargins(ScrollbarPart partType, const IntRect& oldRect) const
 {
     LayoutScrollbarPart* partLayoutObject = m_parts.get(partType);
     if (!partLayoutObject)
         return oldRect;
 
     partLayoutObject->layout();
 
     IntRect rect = oldRect;
     if (orientation() == HorizontalScrollbar) {
-        rect.setX(rect.x() + partLayoutObject->marginLeft());
-        rect.setWidth(rect.width() - partLayoutObject->marginWidth());
+        rect.setX((rect.x() + partLayoutObject->marginLeft()).toInt());
+        rect.setWidth((rect.width() - partLayoutObject->marginWidth()).toInt());
     } else {
-        rect.setY(rect.y() + partLayoutObject->marginTop());
-        rect.setHeight(rect.height() - partLayoutObject->marginHeight());
+        rect.setY((rect.y() + partLayoutObject->marginTop()).toInt());
+        rect.setHeight((rect.height() - partLayoutObject->marginHeight()).toInt());
     }
     return rect;
 }
 
 int LayoutScrollbar::minimumThumbLength() const
 {
     LayoutScrollbarPart* partLayoutObject = m_parts.get(ThumbPart);
     if (!partLayoutObject)
         return 0;
     partLayoutObject->layout();
-    return orientation() == HorizontalScrollbar ? partLayoutObject->size().width() : partLayoutObject->size().height();
+    return (orientation() == HorizontalScrollbar ? partLayoutObject->size().width() : partLayoutObject->size().height()).toInt();
 }
 
 void LayoutScrollbar::invalidateDisplayItemClientsOfScrollbarParts()
 {
     for (auto& part : m_parts)
         part.value->invalidateDisplayItemClientsIncludingNonCompositingDescendants(PaintInvalidationScroll);
 }
 
 } // namespace blink