Disallow cast/implicit conversion from LayoutUnit to int/unsigned

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 378 matching lines @@
     return !m_firstLayout;
 }
 
 void FrameView::invalidateRect(const IntRect& rect)
 {
     LayoutPartItem layoutItem = m_frame->ownerLayoutItem();
     if (layoutItem.isNull())
         return;
 
     IntRect paintInvalidationRect = rect;
-    paintInvalidationRect.move(layoutItem.borderLeft() + layoutItem.paddingLeft(),
-        layoutItem.borderTop() + layoutItem.paddingTop());
+    paintInvalidationRect.move((layoutItem.borderLeft() + layoutItem.paddingLeft()).toInt(),
+        (layoutItem.borderTop() + layoutItem.paddingTop()).toInt());
     // FIXME: We should not allow paint invalidation out of paint invalidation state. crbug.com/457415
     DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;
     layoutItem.invalidatePaintRectangle(LayoutRect(paintInvalidationRect));
 }
 
 void FrameView::setFrameRect(const IntRect& newRect)
 {
     IntRect oldRect = frameRect();
     if (newRect == oldRect)
         return;
@@ skipping 2537 matching lines @@
             layoutView->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(LayoutInvalidationReason::PrintingChanged);
             layout();
 
             const LayoutRect& updatedDocumentRect = LayoutRect(layoutView->documentRect());
             LayoutUnit docLogicalHeight = horizontalWritingMode ? updatedDocumentRect.height() : updatedDocumentRect.width();
             LayoutUnit docLogicalTop = horizontalWritingMode ? updatedDocumentRect.y() : updatedDocumentRect.x();
             LayoutUnit docLogicalRight = horizontalWritingMode ? updatedDocumentRect.maxX() : updatedDocumentRect.maxY();
             LayoutUnit clippedLogicalLeft;
             if (!layoutView->style()->isLeftToRightDirection())
                 clippedLogicalLeft = LayoutUnit(docLogicalRight - pageLogicalWidth);
-            LayoutRect overflow(clippedLogicalLeft, docLogicalTop, pageLogicalWidth, docLogicalHeight);
+            // TODO(crbug.com/638981): Are the conversions to int intentional?
+            LayoutRect overflow(clippedLogicalLeft.toInt(), docLogicalTop.toInt(), pageLogicalWidth, docLogicalHeight.toInt());
 
             if (!horizontalWritingMode)
                 overflow = overflow.transposedRect();
             layoutView->clearLayoutOverflow();
             layoutView->addLayoutOverflow(overflow); // This is how we clip in case we overflow again.
         }
     }
 
     adjustViewSizeAndLayout();
 }
@@ skipping 43 matching lines @@
 IntRect FrameView::convertToContainingWidget(const IntRect& localRect) const
 {
     if (const FrameView* parentView = toFrameView(parent())) {
         // Get our layoutObject in the parent view
         LayoutPart* layoutObject = m_frame->ownerLayoutObject();
         if (!layoutObject)
             return localRect;
 
         IntRect rect(localRect);
         // Add borders and padding??
-        rect.move(layoutObject->borderLeft() + layoutObject->paddingLeft(),
-            layoutObject->borderTop() + layoutObject->paddingTop());
+        rect.move((layoutObject->borderLeft() + layoutObject->paddingLeft()).toInt(),
+            (layoutObject->borderTop() + layoutObject->paddingTop()).toInt());
         return parentView->convertFromLayoutObject(*layoutObject, rect);
     }
 
     return localRect;
 }
 
 IntRect FrameView::convertFromContainingWidget(const IntRect& parentRect) const
 {
     if (const FrameView* parentView = toFrameView(parent())) {
         // Get our layoutObject in the parent view
         LayoutPart* layoutObject = m_frame->ownerLayoutObject();
         if (!layoutObject)
             return parentRect;
 
         IntRect rect = parentView->convertToLayoutObject(*layoutObject, parentRect);
         // Subtract borders and padding
-        rect.move(-layoutObject->borderLeft() - layoutObject->paddingLeft(),
-            -layoutObject->borderTop() - layoutObject->paddingTop());
+        rect.move((-layoutObject->borderLeft() - layoutObject->paddingLeft()).toInt(),
+            (-layoutObject->borderTop() - layoutObject->paddingTop().toInt()));
         return rect;
     }
 
     return parentRect;
 }
 
 IntPoint FrameView::convertToContainingWidget(const IntPoint& localPoint) const
 {
     if (const FrameView* parentView = toFrameView(parent())) {
         // Get our layoutObject in the parent view
         LayoutPart* layoutObject = m_frame->ownerLayoutObject();
         if (!layoutObject)
             return localPoint;
 
         IntPoint point(localPoint);
 
         // Add borders and padding
-        point.move(layoutObject->borderLeft() + layoutObject->paddingLeft(),
-            layoutObject->borderTop() + layoutObject->paddingTop());
+        point.move((layoutObject->borderLeft() + layoutObject->paddingLeft()).toInt(),
+            (layoutObject->borderTop() + layoutObject->paddingTop()).toInt());
         return parentView->convertFromLayoutObject(*layoutObject, point);
     }
 
     return localPoint;
 }
 
 IntPoint FrameView::convertFromContainingWidget(const IntPoint& parentPoint) const
 {
     if (const FrameView* parentView = toFrameView(parent())) {
         // Get our layoutObject in the parent view
         LayoutPart* layoutObject = m_frame->ownerLayoutObject();
         if (!layoutObject)
             return parentPoint;
 
         IntPoint point = parentView->convertToLayoutObject(*layoutObject, parentPoint);
         // Subtract borders and padding
-        point.move(-layoutObject->borderLeft() - layoutObject->paddingLeft(),
-            -layoutObject->borderTop() - layoutObject->paddingTop());
+        point.move((-layoutObject->borderLeft() - layoutObject->paddingLeft()).toInt(),
+            (-layoutObject->borderTop() - layoutObject->paddingTop()).toInt());
         return point;
     }
 
     return parentPoint;
 }
 
 void FrameView::setInitialTracksPaintInvalidationsForTesting(bool trackPaintInvalidations)
 {
     s_initialTrackAllPaintInvalidations = trackPaintInvalidations;
 }
@@ skipping 1247 matching lines @@
 }
 
 bool FrameView::canThrottleRendering() const
 {
     if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
         return false;
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 } // namespace blink