Disallow cast/implicit conversion from LayoutUnit to int/unsigned

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@gmail.com>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 462 matching lines @@
     return layer()->size().height();
 }
 
 int PaintLayerScrollableArea::visibleWidth() const
 {
     return layer()->size().width();
 }
 
 IntSize PaintLayerScrollableArea::contentsSize() const
 {
-    return IntSize(scrollWidth(), scrollHeight());
+    return IntSize(scrollWidth().toInt(), scrollHeight().toInt());
 }
 
 IntPoint PaintLayerScrollableArea::lastKnownMousePosition() const
 {
     return box().frame() ? box().frame()->eventHandler().lastKnownMousePosition() : IntPoint();
 }
 
 bool PaintLayerScrollableArea::scrollAnimatorEnabled() const
 {
     if (Settings* settings = box().frame()->settings())
@@ skipping 216 matching lines @@
         }
     }
 
     {
         // Hits in compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html.
         DisableCompositingQueryAsserts disabler;
 
         // Set up the range (and page step/line step).
         if (Scrollbar* horizontalScrollbar = this->horizontalScrollbar()) {
             int clientWidth = box().pixelSnappedClientWidth();
-            horizontalScrollbar->setProportion(clientWidth, overflowRect().width());
+            horizontalScrollbar->setProportion(clientWidth, overflowRect().width().toInt());
         }
         if (Scrollbar* verticalScrollbar = this->verticalScrollbar()) {
             int clientHeight = box().pixelSnappedClientHeight();
-            verticalScrollbar->setProportion(clientHeight, overflowRect().height());
+            verticalScrollbar->setProportion(clientHeight, overflowRect().height().toInt());
         }
     }
 
     if (!scrollbarsAreFrozen && hasOverlayScrollbars()) {
         if (!scrollSize(HorizontalScrollbar))
             setHasHorizontalScrollbar(false);
         if (!scrollSize(VerticalScrollbar))
             setHasVerticalScrollbar(false);
     }
 
@@ skipping 183 matching lines @@
     m_topmostScrollChild = m_nextTopmostScrollChild;
     m_nextTopmostScrollChild = nullptr;
     return layersChanged;
 }
 
 void PaintLayerScrollableArea::updateAfterOverflowRecalc()
 {
     updateScrollDimensions();
     if (Scrollbar* horizontalScrollbar = this->horizontalScrollbar()) {
         int clientWidth = box().pixelSnappedClientWidth();
-        horizontalScrollbar->setProportion(clientWidth, overflowRect().width());
+        horizontalScrollbar->setProportion(clientWidth, overflowRect().width().toInt());
     }
     if (Scrollbar* verticalScrollbar = this->verticalScrollbar()) {
         int clientHeight = box().pixelSnappedClientHeight();
-        verticalScrollbar->setProportion(clientHeight, overflowRect().height());
+        verticalScrollbar->setProportion(clientHeight, overflowRect().height().toInt());
     }
 
     bool hasHorizontalOverflow = this->hasHorizontalOverflow();
     bool hasVerticalOverflow = this->hasVerticalOverflow();
     bool autoHorizontalScrollbarChanged = box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow);
     bool autoVerticalScrollbarChanged = box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow);
     if (autoHorizontalScrollbarChanged || autoVerticalScrollbarChanged)
         box().setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Unknown);
 }
 
@@ skipping 34 matching lines @@
 {
     int x = minX + box().borderLeft();
     if (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft())
         x += hasVerticalScrollbar() ? verticalScrollbar()->width() : resizerCornerRect(box().pixelSnappedBorderBoxRect(), ResizerForPointer).width();
     return x;
 }
 
 IntSize PaintLayerScrollableArea::scrollbarOffset(const Scrollbar& scrollbar) const
 {
     if (&scrollbar == verticalScrollbar())
-        return IntSize(verticalScrollbarStart(0, box().size().width()), box().borderTop());
+        return IntSize(verticalScrollbarStart(0, box().size().width().toInt()), box().borderTop());
 
     if (&scrollbar == horizontalScrollbar())
-        return IntSize(horizontalScrollbarStart(0), box().size().height() - box().borderBottom() - scrollbar.height());
+        return IntSize(horizontalScrollbarStart(0), (box().size().height() - box().borderBottom() - scrollbar.height()).toInt());
 
     ASSERT_NOT_REACHED();
     return IntSize();
 }
 
 static inline const LayoutObject& layoutObjectForScrollbar(const LayoutObject& layoutObject)
 {
     if (Node* node = layoutObject.node()) {
         if (layoutObject.isLayoutView()) {
             Document& doc = node->document();
@@ skipping 172 matching lines @@
 
     IntRect resizeControlRect;
     if (box().style()->resize() != RESIZE_NONE) {
         resizeControlRect = resizerCornerRect(box().pixelSnappedBorderBoxRect(), ResizerForPointer);
         if (resizeControlRect.contains(localPoint))
             return true;
     }
 
     int resizeControlSize = max(resizeControlRect.height(), 0);
     if (hasVerticalScrollbar() && verticalScrollbar()->shouldParticipateInHitTesting()) {
-        LayoutRect vBarRect(verticalScrollbarStart(0, box().size().width()),
-            LayoutUnit(box().borderTop()),
+        // TODO(crbug.com/638981): Are the conversions to int intentional?
+        LayoutRect vBarRect(verticalScrollbarStart(0, box().size().width().toInt()),
+            box().borderTop(),
             verticalScrollbar()->width(),
-            box().size().height() - (box().borderTop() + box().borderBottom()) - (hasHorizontalScrollbar() ? horizontalScrollbar()->height() : resizeControlSize));
+            (box().size().height() - (box().borderTop() + box().borderBottom()) - (hasHorizontalScrollbar() ? horizontalScrollbar()->height() : resizeControlSize)).toInt());
         if (vBarRect.contains(localPoint)) {
             result.setScrollbar(verticalScrollbar());
             return true;
         }
     }
 
     resizeControlSize = max(resizeControlRect.width(), 0);
     if (hasHorizontalScrollbar() && horizontalScrollbar()->shouldParticipateInHitTesting()) {
-        LayoutRect hBarRect(horizontalScrollbarStart(LayoutUnit()),
-            box().size().height() - box().borderBottom() - horizontalScrollbar()->height(),
-            box().size().width() - (box().borderLeft() + box().borderRight()) - (hasVerticalScrollbar() ? verticalScrollbar()->width() : resizeControlSize),
+        // TODO(crbug.com/638981): Are the conversions to int intentional?
+        LayoutRect hBarRect(horizontalScrollbarStart(0),
+            (box().size().height() - box().borderBottom() - horizontalScrollbar()->height()).toInt(),
+            (box().size().width() - (box().borderLeft() + box().borderRight()) - (hasVerticalScrollbar() ? verticalScrollbar()->width() : resizeControlSize)).toInt(),
             horizontalScrollbar()->height());
         if (hBarRect.contains(localPoint)) {
             result.setScrollbar(horizontalScrollbar());
             return true;
         }
     }
 
     // FIXME: We should hit test the m_scrollCorner and pass it back through the result.
 
     return false;
@@ skipping 563 matching lines @@
 
 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAreas()
 {
     for (auto& scrollableArea : *s_needsClamp)
         scrollableArea->clampScrollPositionsAfterLayout();
     delete s_needsClamp;
     s_needsClamp = nullptr;
 }
 
 } // namespace blink