Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2261653002: [M53-cherrypick] Migrate ArcUserDataService into ArcAuthService. (Closed)

Created:
4 years, 4 months ago by hidehiko
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Migrate ArcUserDataService into ArcAuthService. There are race problems around data removing. One of the cause is that state management is done in ArcAuthService and ArcUserDataService separately. This CL migrates ArcUserDataService into ArcAuthService so that we can remove the data when necessary. BUG=633258, 636218 TEST=Ran manually. - "Enable -> ARC boot wait -> Disable" triggers data removal after ARC stop. - "Enable -> Disable before ARC boot" triggers immediate data removal. - "Enable -> ARC boot wait -> Kill ARC instance" does not trigger data removal. NOTRY=true NOPRESUBMIT=true TBR=dspaid@chromium.org, lhchavez@chromium.org, stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2209173002 Cr-Commit-Position: refs/heads/master@{#411923} (cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae)

Patch Set 1 #

Patch Set 2 : Fix compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -33 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 5 chunks +53 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_enterprise_reporting_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_enterprise_reporting_service.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M components/arc/arc_service_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M components/arc/arc_service_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
hidehiko
Yury, thank you for pointing out compile error, and sorry for inconvenience. This is relanding ...
4 years, 4 months ago (2016-08-19 06:22:51 UTC) #4
Luis Héctor Chávez
lgtm if it compiles
4 years, 4 months ago (2016-08-19 06:24:09 UTC) #6
dspaid
lgtm
4 years, 4 months ago (2016-08-19 06:36:38 UTC) #7
hidehiko
On 2016/08/19 06:36:38, dspaid wrote: > lgtm Thank you for review. Yury, friendly ping?
4 years, 4 months ago (2016-08-23 02:03:37 UTC) #9
khmel
On 2016/08/23 02:03:37, hidehiko wrote: > On 2016/08/19 06:36:38, dspaid wrote: > > lgtm > ...
4 years, 4 months ago (2016-08-24 01:05:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261653002/40001
4 years, 4 months ago (2016-08-25 01:26:02 UTC) #12
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-08-25 01:26:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261653002/40001
4 years, 4 months ago (2016-08-25 01:34:05 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 02:05:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698