Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2261643002: [wasm] removed redundant load line from mjsunit test (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] removed redundant load line from mjsunit test BUG= Committed: https://crrev.com/d64bd5f50626aefcf35d4c9acea71f9b6bd90d9e Cr-Commit-Position: refs/heads/master@{#38735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M test/mjsunit/wasm/ensure-wasm-binaries-up-to-date.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Mircea Trofin
4 years, 4 months ago (2016-08-19 04:25:28 UTC) #5
bradnelson
lgtm from v8 side (as it's included their by the harness), but was the idea ...
4 years, 4 months ago (2016-08-19 05:53:52 UTC) #8
Mircea Trofin
On 2016/08/19 05:53:52, bradnelson wrote: > lgtm from v8 side (as it's included their by ...
4 years, 4 months ago (2016-08-19 06:11:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261643002/1
4 years, 4 months ago (2016-08-19 06:11:16 UTC) #12
Mircea Trofin
4 years, 4 months ago (2016-08-19 06:11:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 06:12:59 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 06:13:20 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d64bd5f50626aefcf35d4c9acea71f9b6bd90d9e
Cr-Commit-Position: refs/heads/master@{#38735}

Powered by Google App Engine
This is Rietveld 408576698