PVer4: Re-use the PVer3 implementation to get full hashes

components/safe_browsing_db/v4_protocol_manager_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_
 
 // A class that implements the stateless methods used by the GetHashUpdate and
 // GetFullHash stubby calls made by Chrome using the SafeBrowsing V4 protocol.
 
 #include <ostream>
 #include <string>
 
 #include "base/gtest_prod_util.h"
 #include "base/hash.h"
 #include "base/strings/string_piece.h"
 #include "components/safe_browsing_db/safebrowsing.pb.h"
 #include "net/url_request/url_request_status.h"
 #include "url/gurl.h"
 
 namespace net {
 class HttpRequestHeaders;
 }  // namespace net
 
+struct EnumClassHash {
+  template <typename T>
+  std::size_t operator()(T t) const {
+    return static_cast<std::size_t>(t);
+  }
+};
+
 namespace safe_browsing {
 
 // A hash prefix sent by the SafeBrowsing PVer4 service.
 typedef std::string HashPrefix;
 
 // A full SHA256 hash.
 typedef HashPrefix FullHash;
 
 typedef FetchThreatListUpdatesRequest::ListUpdateRequest ListUpdateRequest;
 typedef FetchThreatListUpdatesResponse::ListUpdateResponse ListUpdateResponse;
@@ skipping 175 matching lines @@
   // Given a URL, returns all the paths we need to check.
   static void GeneratePathsToCheck(const GURL& url,
                                    std::vector<std::string>* paths);
 
   static std::string RemoveConsecutiveChars(base::StringPiece str,
                                             const char c);
 
   DISALLOW_COPY_AND_ASSIGN(V4ProtocolManagerUtil);
 };
 
+typedef base::hash_set<PlatformType, EnumClassHash> PlatformTypeSet;
+typedef base::hash_set<ThreatEntryType, EnumClassHash> ThreatEntryTypeSet;
+typedef base::hash_set<ThreatType, EnumClassHash> ThreatTypeSet;

[Scott Hess - ex-Googler, 2016/08/23 20:25:46]

These feel like more-expensive versions of std::bit_set<>, both in terms of
storage and CPU.

+
 }  // namespace safe_browsing
 
 namespace std {
 template <>
 struct hash<safe_browsing::UpdateListIdentifier> {
   std::size_t operator()(const safe_browsing::UpdateListIdentifier& s) const {
     return s.hash();
   }
 };
 }
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_