components/component_updater/component_updater_service_internal.h - Issue 2261533003: Provide a callback for Component Updater OnDemand calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/component_updater_service_internal.h

Issue 2261533003: Provide a callback for Component Updater OnDemand calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for cast Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/component_updater/component_updater_service.cc ('k') | components/component_updater/component_updater_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/component_updater_service_internal.h

diff --git a/components/component_updater/component_updater_service_internal.h b/components/component_updater/component_updater_service_internal.h

index fe20526be0fb60d5aaf4fd03f4fb53332f015c50..314cd50b7c430cd322197b308f16e3861c756514 100644

--- a/components/component_updater/component_updater_service_internal.h

+++ b/components/component_updater/component_updater_service_internal.h

@@ -56,7 +56,8 @@ class CrxUpdateService : public ComponentUpdateService,

void OnEvent(Events event, const std::string& id) override;

// Overrides for OnDemandUpdater.

- bool OnDemandUpdate(const std::string& id) override;

+ void OnDemandUpdate(const std::string& id,

+ CompletionCallback callback) override;

private:

void Start();

@@ -64,7 +65,8 @@ class CrxUpdateService : public ComponentUpdateService,

bool CheckForUpdates();

- bool OnDemandUpdateInternal(const std::string& id);

+ void OnDemandUpdateInternal(const std::string& id,

+ CompletionCallback callback);

bool OnDemandUpdateWithCooldown(const std::string& id);

bool DoUnregisterComponent(const CrxComponent& component);

@@ -75,7 +77,9 @@ class CrxUpdateService : public ComponentUpdateService,

void OnUpdate(const std::vector<std::string>& ids,

std::vector<CrxComponent>* components);

- void OnUpdateComplete(const base::TimeTicks& start_time, int error);

+ void OnUpdateComplete(CompletionCallback callback,

+ const base::TimeTicks& start_time,

+ int error);

base::ThreadChecker thread_checker_;