Provide a callback for Component Updater OnDemand calls.

chrome/browser/component_updater/supervised_user_whitelist_installer.cc

Index: chrome/browser/component_updater/supervised_user_whitelist_installer.cc
diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
index ef24cd25d1b07b876c31ea0f6964c52e7761c766..879773d8157ee4ec789bf1c2ca34a666bbf37b10 100644
--- a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
@@ -642,8 +642,7 @@ std::vector<uint8_t> SupervisedUserWhitelistInstaller::GetHashFromCrxId(
 void SupervisedUserWhitelistInstaller::TriggerComponentUpdate(
     OnDemandUpdater* updater,
     const std::string& crx_id) {
-  const bool result = updater->OnDemandUpdate(crx_id);
-  DCHECK(result);
+  updater->OnDemandUpdate(crx_id, ComponentUpdateService::CompletionCallback());

[Bernhard Bauer, 2016/08/19 04:13:05]

Could we DCHECK the result in a callback here? If you don't want to add the
overhead for a release build, feel free to pass the null callback if DCHECKs are
compiled out.

[Sorin Jianu, 2016/08/19 04:23:36]

I will try to add the callback. I am not concerned about the overhead, I just
tried to keep the change mechanical for the existing callers, and hopefully,
people would take advantage of the callbacks.

[Sorin Jianu, 2016/08/19 04:43:36]

On a second thought, I prefer solving this in a future change list to keep the
mechanical aspect of this change. The DCHECK is mostly pedantic, as the existing
code returned a hardcoded true in the interesting case.

 }
 
 }  // namespace component_updater