Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2261533002: Fix serializing of 'unset' sub-properties (Closed)

Created:
4 years, 4 months ago by rwlbuis
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix serializing of 'unset' sub-properties Like the other CSS wide keywords, 'unset' should only be serialized for sub-properties if all sub-properties have the value 'unset'. [1] [1] http://dev.w3.org/csswg/cssom/#serialize-a-css-value Committed: https://crrev.com/c64227581e65ab0a0b443909e34a12f90577cb9e Cr-Commit-Position: refs/heads/master@{#413044}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/background-serialize.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL.
4 years, 4 months ago (2016-08-18 21:46:45 UTC) #4
Timothy Loh
On 2016/08/18 21:46:45, rwlbuis wrote: > PTAL. lgtm
4 years, 4 months ago (2016-08-19 01:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261533002/20001
4 years, 4 months ago (2016-08-19 01:50:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 03:38:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 03:40:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c64227581e65ab0a0b443909e34a12f90577cb9e
Cr-Commit-Position: refs/heads/master@{#413044}

Powered by Google App Engine
This is Rietveld 408576698