Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226153002: Callers of ElementsAccessor::Validate() handlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Callers of ElementsAccessor::Validate() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20532

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing review notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -55 lines) Patch
M src/elements.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/factory.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 chunks +16 lines, -7 lines 0 comments Download
M src/heap.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M src/objects-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-04 15:36:29 UTC) #1
Yang
https://codereview.chromium.org/226153002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/226153002/diff/1/src/heap.cc#newcode4650 src/heap.cc:4650: Handle<JSArray> Heap::AllocateJSArrayWithElements( Since this is now handlified, it belongs ...
6 years, 8 months ago (2014-04-07 07:20:47 UTC) #2
Igor Sheludko
https://codereview.chromium.org/226153002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/226153002/diff/1/src/heap.cc#newcode4650 src/heap.cc:4650: Handle<JSArray> Heap::AllocateJSArrayWithElements( On 2014/04/07 07:20:48, Yang wrote: > Since ...
6 years, 8 months ago (2014-04-07 09:29:16 UTC) #3
Yang
lgtm.
6 years, 8 months ago (2014-04-07 09:30:32 UTC) #4
Igor Sheludko
6 years, 8 months ago (2014-04-07 10:00:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r20532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698