base/version.h - Issue 2261523006: Disallow non-namespaced use of base::Version.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/version.h

Issue 2261523006: Disallow non-namespaced use of base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed newly introduced use of base::Version. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_VERSION_H_	5 #ifndef BASE_VERSION_H_

6 #define BASE_VERSION_H_	6 #define BASE_VERSION_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <iosfwd>	10 #include <iosfwd>

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 BASE_EXPORT bool operator==(const Version& v1, const Version& v2);	66 BASE_EXPORT bool operator==(const Version& v1, const Version& v2);

67 BASE_EXPORT bool operator!=(const Version& v1, const Version& v2);	67 BASE_EXPORT bool operator!=(const Version& v1, const Version& v2);

68 BASE_EXPORT bool operator<(const Version& v1, const Version& v2);	68 BASE_EXPORT bool operator<(const Version& v1, const Version& v2);

69 BASE_EXPORT bool operator<=(const Version& v1, const Version& v2);	69 BASE_EXPORT bool operator<=(const Version& v1, const Version& v2);

70 BASE_EXPORT bool operator>(const Version& v1, const Version& v2);	70 BASE_EXPORT bool operator>(const Version& v1, const Version& v2);

71 BASE_EXPORT bool operator>=(const Version& v1, const Version& v2);	71 BASE_EXPORT bool operator>=(const Version& v1, const Version& v2);

72 BASE_EXPORT std::ostream& operator<<(std::ostream& stream, const Version& v);	72 BASE_EXPORT std::ostream& operator<<(std::ostream& stream, const Version& v);

73	73

74 } // namespace base	74 } // namespace base

75	75

76 // TODO(xhwang) remove this when all users are updated to explicitly use the

77 // namespace

78 using base::Version;

79

80 #endif // BASE_VERSION_H_	76 #endif // BASE_VERSION_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »