Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9534)

Unified Diff: chrome/browser/web_dev_style/css_checker_test.py

Issue 2261523005: Presubmit test for overriding properties generated by Polymer mixin shim (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/css_checker_test.py
diff --git a/chrome/browser/web_dev_style/css_checker_test.py b/chrome/browser/web_dev_style/css_checker_test.py
index 461cc2b381c5000aa2948736983434958dfa7320..4b1cd3e9bcdec1134038293f25c695ff7425f861 100755
--- a/chrome/browser/web_dev_style/css_checker_test.py
+++ b/chrome/browser/web_dev_style/css_checker_test.py
@@ -277,6 +277,16 @@ img {
- Don't use data URIs in source files. Use grit instead.
background: url( data:image/jpeg,4\/\/350|\/|3|2 );""")
+ def testCssNoMixinShims(self):
+ self.VerifyContentsProducesOutput("""
+:host {
+ --good-property: red;
+ --not-okay-mixin_-_not-okay-property: green;
+}""", """
+- Don't override custom properties created by Polymer's mixin shim. Set \
+mixins or documented custom properties directly.
+ --not-okay-mixin_-_not-okay-property: green;""")
+
def testCssNoQuotesInUrl(self):
self.VerifyContentsProducesOutput("""
img {
« no previous file with comments | « chrome/browser/web_dev_style/css_checker.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698