Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2261523002: Temporarily disable incremental_javac for Robolectric. (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
Reviewers:
the real yoland
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable incremental_javac for Robolectric. Building Robolectric currently doesn't work properly with incremental builds. Going to disable incremental_javac for Robolectric till a solution is found. BUG=638875 Committed: https://crrev.com/9de6077604c0b96260a242928028a14b3fe08f2e Cr-Commit-Position: refs/heads/master@{#412944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/robolectric/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mikecase (-- gone --)
4 years, 4 months ago (2016-08-18 18:31:15 UTC) #2
the real yoland
lgtm
4 years, 4 months ago (2016-08-18 18:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261523002/1
4 years, 4 months ago (2016-08-18 18:33:49 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-18 20:43:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261523002/1
4 years, 4 months ago (2016-08-18 21:37:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 21:51:47 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 22:00:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9de6077604c0b96260a242928028a14b3fe08f2e
Cr-Commit-Position: refs/heads/master@{#412944}

Powered by Google App Engine
This is Rietveld 408576698