Define remote playback proto buffer

media/remoting/rpc/decoder_buffer_segment.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_REMOTING_RPC_DECODER_BUFFER_SEGMENT_H_
+#define MEDIA_REMOTING_RPC_DECODER_BUFFER_SEGMENT_H_
+
+#include <cstdint>
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "media/base/decoder_buffer.h"
+#include "media/remoting/remoting_rpc_message.pb.h"
+
+namespace media {
+namespace remoting {
+
+class DecoderBufferSegment
+    : public base::RefCountedThreadSafe<DecoderBufferSegment> {
+ public:
+  explicit DecoderBufferSegment(

[miu, 2016/09/08 01:07:34]

This class should never be instantiated. It contains only one data member,
|decoder_buffer_| which is really just a temporary object and could be provided
by the callers of FromBuffer() and ToBuffer(). (Meaning, FromBuffer() and
ToBuffer() could be static methods.)

Maybe, instead of a class, you just need two utility functions:

void ToByteVector(const media::DecoderBuffer& buffer, std::vector<uint8_t>*
out);

void FromArray(const uint8_t* data, size_t size, media::DecoderBuffer* out);

IMHO, a lot less code that does everything you need. ;)

[erickung1, 2016/09/13 03:52:53]

Done.

+      const scoped_refptr<::media::DecoderBuffer>& decoder_buffer);
+
+  // Converts DecoderBufferSegment into byte array.
+  uint32_t ToBuffer(std::vector<uint8_t>* buffer);
+
+  // Converts byte array into DecoderBufferSegment.
+  static scoped_refptr<DecoderBufferSegment> FromBuffer(const uint8_t* data,
+                                                        uint32_t size);
+
+  scoped_refptr<::media::DecoderBuffer> decoder_buffer() {
+    return decoder_buffer_;
+  }
+
+ private:
+  friend class base::RefCountedThreadSafe<DecoderBufferSegment>;
+  ~DecoderBufferSegment();
+
+  scoped_refptr<::media::DecoderBuffer> decoder_buffer_;
+
+  DISALLOW_COPY_AND_ASSIGN(DecoderBufferSegment);
+};
+
+}  // namespace remoting
+}  // namespace media
+
+#endif  // MEDIA_REMOTING_RPC_DECODER_BUFFER_SEGMENT_H_