Define remote playback proto buffer

media/remoting/rpc/rpc.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_REMOTING_RPC_RPC_H_
+#define MEDIA_REMOTING_RPC_RPC_H_
+
+#include <cstdint>
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "media/base/audio_decoder_config.h"
+#include "media/base/cdm_config.h"
+#include "media/base/cdm_key_information.h"
+#include "media/base/demuxer_stream.h"
+#include "media/base/eme_constants.h"
+#include "media/base/media_keys.h"
+#include "media/base/pipeline_status.h"
+#include "media/base/video_decoder_config.h"
+#include "media/remoting/remoting_rpc_message.pb.h"
+
+namespace media {
+namespace remoting {
+
+class CdmPromiseResult;
+
+extern const int kInvalidHandle;

[miu, 2016/09/13 05:40:58]

These don't seem to be used anywhere. Are you planning on using them in a future
change?

[erickung1, 2016/09/15 02:13:33]

I updated the code to use kReceiverHandle when RPC to acquire renderer and
media_keys
kInvalidHandle will be used by receiver.

+extern const int kReceiverHandle;
+
+void SerializeEncryptionScheme(

[miu, 2016/09/13 05:40:58]

General comment for these Serialize/Deserialize functions:

1. Naming nit: They aren't serializing/deserializing. They just convert between
the ::media::Object type and the protobuf type. So, please name them something
like ConvertFromFooProto() and ConvertToFooProto().

2. Google C++ style: Input arguments go first, output arguments go last.

3. The "convert from" operations are taking data from an external source as
input, and so they should return bools to indicate success/failure (more on this
in rpc.cc file comments). On invalid or unparseable external source input, we
should shut down media remoting.

[erickung1, 2016/09/15 02:13:33]

I made the change for #1 #2 and most #3.
When you say shutdown media remoting, do you mean DCHECK on debug build? or the
normal route in the code to stop remoting??

[miu, 2016/09/16 18:14:13]

Normal route. General guideline: If a value is not what it should be because
there is a bug in the Chrome code, then crash (DCHECK). However, if the value is
wrong because of a transient/environmental error, or because of a receiver-side
bug, then just shut down remoting immediately (because it's not a Chrome code
bug).

+    pb::EncryptionScheme* message,
+    const ::media::EncryptionScheme& encryption_scheme);
+void DeserializeEncryptionScheme(const pb::EncryptionScheme& message,
+                                 ::media::EncryptionScheme* encryption_scheme);
+
+void SerializeAudioConfig(const ::media::AudioDecoderConfig& audio_config,
+                          pb::AudioDecoderConfig* audio_message);
+bool DeserializeAudioConfig(const pb::AudioDecoderConfig& audio_message,
+                            ::media::AudioDecoderConfig* audio_config);
+
+void SerializeVideoConfig(const ::media::VideoDecoderConfig& video_config,
+                          pb::VideoDecoderConfig* video_message);
+bool DeserializeVideoConfig(const pb::VideoDecoderConfig& video_message,
+                            ::media::VideoDecoderConfig* video_config);
+
+void SerializeCdmConfig(const ::media::CdmConfig& cdm_config,
+                        pb::CdmInitialize* message);
+
+void SerializeCdmPromiseResult(pb::CdmPromise* promise_message,
+                               const CdmPromiseResult& result);
+bool DeserializeCdmPromiseResult(const pb::CdmPromise& promise_message,
+                                 CdmPromiseResult* result);
+
+void SerializeCdmKeyInformation(
+    const ::media::CdmKeysInfo& keys_information,
+    pb::CdmClientOnSessionKeysChange* key_change_message);
+bool DeserializeCdmKeyInformation(
+    const pb::CdmClientOnSessionKeysChange keychange_message,
+    CdmKeysInfo* key_information);
+
+bool CdmPromiseFromMessage(const pb::RpcMessage& message,
+                           CdmPromiseResult* result,
+                           int* cdm_id,
+                           std::string* session_id);
+void CdmPromiseToMessage(pb::CdmPromise* promise_message,
+                         const CdmPromiseResult& result,
+                         const std::string& session_id);
+void CdmPromiseWithCdmIdToMessage(pb::CdmPromise* promise_message,
+                                  const CdmPromiseResult& result,
+                                  int cdm_id);
+
+//==================================================================
+class CdmPromiseResult {
+ public:
+  CdmPromiseResult();
+  CdmPromiseResult(::media::MediaKeys::Exception exception,
+                   uint32_t system_code,
+                   std::string error_message);
+  CdmPromiseResult(const CdmPromiseResult& other);
+  ~CdmPromiseResult();
+
+  static CdmPromiseResult SuccessResult();
+
+  bool success() const { return success_; }
+  ::media::MediaKeys::Exception exception() const { return exception_; }
+  uint32_t system_code() const { return system_code_; }
+  const std::string& error_message() const { return error_message_; }
+
+ private:
+  bool success_;
+  ::media::MediaKeys::Exception exception_;
+  uint32_t system_code_;
+  std::string error_message_;
+};
+
+}  // namespace remoting
+}  // namespace media
+
+#endif  // MEDIA_REMOTING_RPC_RPC_H_