Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: components/exo/wm_helper_mus.cc

Issue 2261473002: exo: WMHelperMus: Add focus and activation support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a review issue Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/exo/wm_helper_mus.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/wm_helper_mus.cc
diff --git a/components/exo/wm_helper_mus.cc b/components/exo/wm_helper_mus.cc
index 315a70c4781bca4cb25adf8bb92b36a54a6012f7..46400317b5ee934f4ded13a4e589dcac927debbd 100644
--- a/components/exo/wm_helper_mus.cc
+++ b/components/exo/wm_helper_mus.cc
@@ -5,15 +5,39 @@
#include "components/exo/wm_helper_mus.h"
#include "ash/common/display/display_info.h"
+#include "services/ui/public/cpp/window_tree_client.h"
+#include "ui/aura/client/focus_client.h"
+#include "ui/views/mus/native_widget_mus.h"
+#include "ui/views/mus/window_manager_connection.h"
+#include "ui/views/widget/widget.h"
namespace exo {
+namespace {
+
+aura::Window* GetToplevelAuraWindow(ui::Window* window) {
+ DCHECK(window);
+ // We never create child ui::Window, so window->parent() should be null.
+ DCHECK(!window->parent());
+ views::Widget* widget = views::NativeWidgetMus::GetWidgetForWindow(window);
+ if (!widget)
+ return nullptr;
+ return widget->GetNativeWindow();
+}
+
+} // namespace
////////////////////////////////////////////////////////////////////////////////
// WMHelperMus, public:
-WMHelperMus::WMHelperMus() {}
+WMHelperMus::WMHelperMus()
+ : active_window_(WMHelperMus::GetActiveWindow()),
+ focused_window_(WMHelperMus::GetFocusedWindow()) {
+ views::WindowManagerConnection::Get()->client()->AddObserver(this);
+}
-WMHelperMus::~WMHelperMus() {}
+WMHelperMus::~WMHelperMus() {
+ views::WindowManagerConnection::Get()->client()->RemoveObserver(this);
+}
////////////////////////////////////////////////////////////////////////////////
// WMHelperMus, private:
@@ -29,13 +53,18 @@ aura::Window* WMHelperMus::GetContainer(int container_id) {
}
aura::Window* WMHelperMus::GetActiveWindow() const {
- NOTIMPLEMENTED();
- return nullptr;
+ ui::Window* window =
+ views::WindowManagerConnection::Get()->client()->GetFocusedWindow();
+ return window ? GetToplevelAuraWindow(window) : nullptr;
}
aura::Window* WMHelperMus::GetFocusedWindow() const {
- NOTIMPLEMENTED();
- return nullptr;
+ aura::Window* active_window = GetActiveWindow();
+ if (!active_window)
+ return nullptr;
+ aura::client::FocusClient* focus_client =
+ aura::client::GetFocusClient(active_window);
+ return focus_client->GetFocusedWindow();
}
ui::CursorSetType WMHelperMus::GetCursorSet() const {
@@ -68,4 +97,43 @@ bool WMHelperMus::IsMaximizeModeWindowManagerEnabled() const {
return false;
}
+void WMHelperMus::OnWindowTreeFocusChanged(ui::Window* gained_focus,
+ ui::Window* lost_focus) {
+ aura::Window* gained_active =
+ gained_focus ? GetToplevelAuraWindow(gained_focus) : nullptr;
+ aura::Window* lost_active =
+ lost_focus ? GetToplevelAuraWindow(lost_focus) : nullptr;
+
+ // Because NativeWidgetMus uses separate FocusClient for every toplevel
+ // window, we have to stop observering the FocusClient of the |lost_active|
+ // and start observering the FocusClient of the |gained_active|.
+ if (active_window_) {
+ aura::client::FocusClient* focus_client =
+ aura::client::GetFocusClient(active_window_);
+ focus_client->RemoveObserver(this);
+ }
+
+ active_window_ = gained_active;
+ NotifyWindowActivated(gained_active, lost_active);
+
+ aura::Window* focused_window = nullptr;
+ if (active_window_) {
+ aura::client::FocusClient* focus_client =
+ aura::client::GetFocusClient(active_window_);
+ focus_client->AddObserver(this);
+ focused_window = focus_client->GetFocusedWindow();
+ }
+
+ // OnWindowFocused() will update |focused_window_|.
+ OnWindowFocused(focused_window, focused_window_);
+}
+
+void WMHelperMus::OnWindowFocused(aura::Window* gained_focus,
+ aura::Window* lost_focus) {
+ if (focused_window_ != gained_focus) {
+ focused_window_ = gained_focus;
+ NotifyWindowFocused(gained_focus, lost_focus);
+ }
+}
+
} // namespace exo
« no previous file with comments | « components/exo/wm_helper_mus.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698