Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2261463002: There are only 2 language modes, not 3 (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis, vogelheim, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

There are only 2 language modes, not 3 Use bool is_strict_ to encode language_mode in scopes using a single bit. BUG= Committed: https://crrev.com/4b7dc57f0a010ad883daab7145cd9e0cc3d85654 Cr-Commit-Position: refs/heads/master@{#38724}

Patch Set 1 #

Patch Set 2 : Use set_language_mode() internally #

Patch Set 3 : Undo last_language_mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -39 lines) Patch
M src/ast/scopes.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M src/ast/scopes.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic-state.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +5 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Toon Verwaest
third try, ptal
4 years, 4 months ago (2016-08-18 13:36:32 UTC) #2
vogelheim
lgtm
4 years, 4 months ago (2016-08-18 14:27:54 UTC) #4
neis
lgtm now, thanks
4 years, 4 months ago (2016-08-18 14:41:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261463002/40001
4 years, 4 months ago (2016-08-18 14:54:14 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 15:56:56 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:57:18 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4b7dc57f0a010ad883daab7145cd9e0cc3d85654
Cr-Commit-Position: refs/heads/master@{#38724}

Powered by Google App Engine
This is Rietveld 408576698